Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove zsh as a build dependency #598

Open
puria opened this issue Feb 14, 2023 · 5 comments · May be fixed by #930
Open

Remove zsh as a build dependency #598

puria opened this issue Feb 14, 2023 · 5 comments · May be fixed by #930

Comments

@puria
Copy link
Member

puria commented Feb 14, 2023

Very low priority.

But on a bare new linux machine make linux requires zsh, that maybe we want to avoid, to get closer to our 0-dependency philosophy ;)
@denizenging
Copy link
Member

Tell me if you need help with POSIX-compliant shell scripts.

@jaromil
Copy link
Member

jaromil commented Jul 2, 2023

build/embed-lualibs is the shell script requiring it, where I use some word separator modifiers that are idiomatic to zsh

@jaromil
Copy link
Member

jaromil commented Nov 30, 2023

I think only this modifier needs fixing:

image

@puria
Copy link
Member Author

puria commented Nov 30, 2023 •
edited
Loading

Thnks @srfsh review the code below... could be a good starting point ;)

https://chat.openai.com/share/cd9ba8cd-dff9-45ad-a89e-12fb9356a898

@denizenging
Copy link
Member

Thnks @srfsh review the code below... could be a good starting point ;)

https://chat.openai.com/share/cd9ba8cd-dff9-45ad-a89e-12fb9356a898

I can certainly work on this now, now that I'm more available in general. The first thing I can point out that is wrong in this script is that, posix doesn't have arrays, and this script is outright wrong. :/

@matteo-cristino matteo-cristino linked a pull request Sep 23, 2024 that will close this issue
feat: remove zsh dependency #930
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: remove zsh dependency dyne/Zenroom
3 participants
@puria @jaromil @denizenging