Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG Can't install the newest 4.0.0-beta1 version via composer #34

Open
Valandur opened this issue Jul 25, 2023 · 4 comments
Open

BUG Can't install the newest 4.0.0-beta1 version via composer #34

Valandur opened this issue Jul 25, 2023 · 4 comments

Comments

@Valandur
Copy link

Describe the bug
Installing the newest 4.0.0-beta1 release (directly or as a requirement of dynamic/silverstripe-elemental-gallery @ 4.0.0-beta1) results in a composer error:

Your requirements could not be resolved to an installable set of packages.

because of:

dynamic/silverstripe-elemental-gallery[4.0.0-beta1, ..., 4.x-dev] require dynamic/silverstripe-elemental-baseobject ^4 -> satisfiable by dynamic/silverstripe-elemental-baseobject[4.0.0-alpha1, 4.0.0-beta1, 4.x-dev]
dynamic/silverstripe-elemental-baseobject[4.0.0-beta1, ..., 4.x-dev] require silvershop/silverstripe-hasonefield ^3 -> satisfiable by silvershop/silverstripe-hasonefield[3.0.0, ..., 3.1.0]
silvershop/silverstripe-hasonefield[3.0.0, ..., 3.1.0] require silverstripe/vendor-plugin ^1.0 -> found silverstripe/vendor-plugin[1.0.0, ..., 1.x-dev] but it conflicts with your root composer.json require (^2.0.0)

Most likely because silvershop/silverstripe-hasonefield @ v3 only supports silverstripe/vendor-plugin @ v1, but v2 is required by the silverstripe framework. This module should probably require "silvershop/silverstripe-hasonefield": "^4", since v4 of that module supports using silverstripe/vendor-plugin @ v2.

To Reproduce
Steps to reproduce the behavior:

  1. Create a new SS5 repo
  2. Try to install this module (either directly or as a dependency of another module)

Expected behavior
Module installs successfully

@jsirish
Copy link
Member

jsirish commented Jul 26, 2023

hey thanks @Valandur for reporting the bug!

I've got #35 started to address this. It seems gorriecoe/silverstripe-linkfield will need to have its requirements updated as well for the PR to pass. I have a PR in over there as well, once that's merged this PR should pass and I can merge it in.

@KallivdH
Copy link

Link field has been updated in the meantime.

@jsirish
Copy link
Member

jsirish commented Aug 18, 2023

Hey @KallivdH thanks for the reminder, I thought I had merged the PR.

Just published a new release 4.0.0-beta2, let me know if you have any additional issues.

@lars-lemon8
Copy link

@jsirish , this one seems to work perfectly, thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants