Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linkable - move to ToggleCompositeField #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jsirish
Copy link
Member

@jsirish jsirish commented Aug 9, 2016

fixes #37

@jsirish
Copy link
Member Author

jsirish commented Aug 9, 2016

Some weird UX - toggle field doesn't grow when TreeDropdownField is selected, options are hidden and lots of scrolling necessary.

Prefer to find a way to increase the height of the ToggleCompositeField.

Otherwise, we may need to look at Entwine or CSS solutions

@jsirish jsirish force-pushed the feature/linkableToggleField branch from 8c39cd7 to 5d4da84 Compare August 9, 2016 15:55
@jsirish jsirish force-pushed the feature/linkableToggleField branch from 5d4da84 to 086f2ab Compare August 9, 2016 21:01
@dynamic-dedicated
Copy link

dynamic-dedicated commented Aug 9, 2016

Current coverage is 83.29% (diff: 100%)

Merging #38 into master will increase coverage by 0.39%

@@             master        #38   diff @@
==========================================
  Files            18         18          
  Lines           380        389     +9   
  Methods          56         56          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            315        324     +9   
  Misses           65         65          
  Partials          0          0          

Powered by Codecov. Last update edac04f...086f2ab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linkable
2 participants