Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sound adjustment while playing #114

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

CGaneshKumar2002
Copy link
Contributor

👉 Checklist

Please make sure to check off the following before submitting:

  • I have reviewed my submission thoroughly.
  • I have tested my code (if submission is related to coding) and run the game before pushing (to make sure the project compile).
  • I have run the JUnit tests (if submission is related to coding).
  • I have read the Code of Conduct and Contribution Guidelines.

✍ Description of the Pull Request

Added ingame settings to control the game background music and sfx sounds
Incorporated dynamic assignment of sound icons depending on volume
Built an universal SoundController system for maintaining sounds using a singleton instance.

🔗 Issue link

Closes #112


@CGaneshKumar2002
Copy link
Contributor Author

Screenshot for reference:
image

@jvondermarck
Copy link
Collaborator

Thanks for your contribution !!

@jvondermarck jvondermarck added the invalid This doesn't seem right label Dec 24, 2024
@jvondermarck
Copy link
Collaborator

Please fix the issues

Error:  Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project dinosaur-exploder: Compilation failure
Error:  /home/runner/work/dinosaur-exploder/dinosaur-exploder/src/main/java/com/dinosaur/dinosaurexploder/view/PauseMenu.java:[28,21] package org.jetbrains.annotations is not visible
Error:    (package org.jetbrains.annotations is declared in module com.almasb.fxgl.core, which does not export it)
Error:  -> [Help 1]
Error:  
Error:  To see the full stack trace of the errors, re-run Maven with the -e switch.
Error:  Re-run Maven using the -X switch to enable full debug logging.
Error:  
Error:  For more information about the errors and possible solutions, please read the following articles:
Error:  [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
Error: Process completed with exit code 1.

@jvondermarck jvondermarck added the bug Something isn't working label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Adjust the sound volume while playing
2 participants