Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commands may throw exceptions when outside a game #184

Open
rolandwalker opened this issue Sep 11, 2021 · 0 comments
Open

Commands may throw exceptions when outside a game #184

rolandwalker opened this issue Sep 11, 2021 · 0 comments

Comments

@rolandwalker
Copy link
Collaborator

Example

(goto-char (point-max))

M-x pygn-mode-echo-fen-at-pos
; Wrong type argument: integer-or-marker-p, nil

Tree-sitter brought a deeper understanding of the structure of the file, and is naturally more strict. But this does not match the previous behavior. In addition, if an exception is to be thrown, it must be meaningful. This needs testing, and thinking through.

Intuitively, I think some of the defuns could reman strict in their understanding of placement in the buffer, but the commands made more lenient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant