Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is parameter samples ignored? #20

Open
engel75 opened this issue Nov 18, 2019 · 1 comment
Open

Is parameter samples ignored? #20

engel75 opened this issue Nov 18, 2019 · 1 comment

Comments

@engel75
Copy link

engel75 commented Nov 18, 2019

It looks like -samples 1000000 or, eg. -samples 100 makes no difference. Shouldn't 1000000 samples take longer than 100?
@engel75
Copy link
Author

engel75 commented Nov 18, 2019

Ok got it. Looks like you overwrite the value by

samples := getTargetSampleCount(threadCount, samples)

not sure if that makes sense...
Maybe you should allow users to enable and disable this overwrite?
Any I guess samples should be raltive to the object size? It would take quite long to get 100000 32MB objects?
So maybe instead of overwriting it you allow a time based benchmark? so each sample size is running for the same amount of time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@engel75