Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading name/description of payload parameter #10

Open
smedelyan opened this issue Jul 2, 2019 · 0 comments
Open

Misleading name/description of payload parameter #10

smedelyan opened this issue Jul 2, 2019 · 0 comments

Comments

@smedelyan
Copy link

It says:

The minimum object size to test, with 1 = 1 KB

I had to look through the code to understand that "payload" is a power of 2 which is then multiplied by 1KB. So, in short:

# assuming payload is > 0
multiplier = 2 ^ (payload - 1)
object_min_size = 1KB * multiplier

So, you see, you have to pass -payload-min=16 to get 32 MB object, and -payload-min=17 to get 64 MB object while the parameter clearly says it is an object size. Why is it encoded in such a weird way then?

Same applies to payload-max. I suggest either renaming this parameter to something better corresponding to the actual meaning, or - even better - allow user to define object min and max size like:
-payload-min=1000 - meaning 1 MB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant