From 26fb61ab413a316f43d4149619332816cb1e6052 Mon Sep 17 00:00:00 2001 From: Stephan Max Date: Sat, 31 Oct 2015 09:59:51 +0000 Subject: [PATCH] Fixed issue #177 by replacing 'char' with 'chr' --- coffee/requests.coffee | 4 ++-- js/requests.js | 6 +++--- offline.js | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/coffee/requests.coffee b/coffee/requests.coffee index 12b1192..4b1ddd1 100644 --- a/coffee/requests.coffee +++ b/coffee/requests.coffee @@ -36,8 +36,8 @@ flush = -> # TODO: Throw out PUT/POST/DELETE requests after too much time? for request in held # Break cache breaking - url = request.url.replace /(\?|&)_=[0-9]+/, (match, char) -> - if char is '?' then char else '' + url = request.url.replace /(\?|&)_=[0-9]+/, (match, chr) -> + if chr is '?' then chr else '' if Offline.getOption('deDupBody') body = request.body diff --git a/js/requests.js b/js/requests.js index 22ddac6..f6e0b47 100644 --- a/js/requests.js +++ b/js/requests.js @@ -52,9 +52,9 @@ requests = {}; for (i = 0, len = held.length; i < len; i++) { request = held[i]; - url = request.url.replace(/(\?|&)_=[0-9]+/, function(match, char) { - if (char === '?') { - return char; + url = request.url.replace(/(\?|&)_=[0-9]+/, function(match, chr) { + if (chr === '?') { + return chr; } else { return ''; } diff --git a/offline.js b/offline.js index ba4bf50..f0a07c5 100644 --- a/offline.js +++ b/offline.js @@ -185,8 +185,8 @@ var body, i, key, len, request, requests, url; if (Offline.getOption("requests") !== !1) { for (Offline.trigger("requests:flush"), requests = {}, i = 0, len = held.length; len > i; i++) request = held[i], - url = request.url.replace(/(\?|&)_=[0-9]+/, function(match, char) { - return "?" === char ? char :""; + url = request.url.replace(/(\?|&)_=[0-9]+/, function(match, chr) { + return "?" === chr ? chr :""; }), Offline.getOption("deDupBody") ? (body = request.body, body = "[object Object]" === body.toString() ? JSON.stringify(body) :body.toString(), requests[request.type.toUpperCase() + " - " + url + " - " + body] = request) :requests[request.type.toUpperCase() + " - " + url] = request; for (key in requests) request = requests[key], makeRequest(request);