Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DEPRECATED logs generate by Symfony 6.3 #1399

Closed
JoDarma-lp opened this issue Aug 4, 2023 · 13 comments
Closed

Fix DEPRECATED logs generate by Symfony 6.3 #1399

JoDarma-lp opened this issue Aug 4, 2023 · 13 comments

Comments

@JoDarma-lp
Copy link

JoDarma-lp commented Aug 4, 2023

Registering \"Vich\\UploaderBundle\\EventListener\\Doctrine\\RemoveListener\" as a Doctrine subscriber is deprecated. Register it as a listener instead, using e.g. the #[AsDoctrineListener] attribute
Registering \"Vich\\UploaderBundle\\EventListener\\Doctrine\\UploadListener\" as a Doctrine subscriber is deprecated. Register it as a listener instead, using e.g. the #[AsDoctrineListener] attribute
Registering \"Vich\\UploaderBundle\\EventListener\\Doctrine\\CleanListener\" as a Doctrine subscriber is deprecated. Register it as a listener instead, using e.g. the #[AsDoctrineListener] attribute.
Registering \"Vich\\UploaderBundle\\EventListener\\Doctrine\\RemoveListener\" as a Doctrine subscriber is deprecated. Register it as a listener instead, using e.g. the #[AsDoctrineListener] attribute
Registering \"Vich\\UploaderBundle\\EventListener\\Doctrine\\UploadListener\" as a Doctrine subscriber is deprecated. Register it as a listener instead, using e.g. the #[AsDoctrineListener] attribute

You should to update the code to use new attribute #[AsDoctrineListener] to avoir Symfony deprecated message when using your Bundle.

@garak
Copy link
Collaborator

garak commented Aug 4, 2023

Duplicate of #1388

@garak garak marked this as a duplicate of #1388 Aug 4, 2023
@garak garak closed this as completed Aug 4, 2023
@JoDarma-lp
Copy link
Author

Yep, but deprecated message are always logs #1391 doesn't totally fix the deprecated message

@mdriessen
Copy link

@garak Do you have any timeline for tagging a new release with these fixes?

@garak
Copy link
Collaborator

garak commented Aug 9, 2023

@garak Do you have any timeline for tagging a new release with these fixes?

it looks like the deprecations is not solved...

@mdriessen
Copy link

@garak Do you have any timeline for tagging a new release with these fixes?

it looks like the deprecations is not solved...

I'm on Symfony 6.3 and getting the deprecations on VichUploader v2.1.1. When switching to dev-master (05f4df4) the deprecations are solved. Using the attribute #[AsDoctrineListener] is not required, it's just a possible way of registering the listener instead of configuring it in XML.

So I'm not sure what @JoDarma-lp is referring to... did you try the dev-master version?

@JoDarma-lp
Copy link
Author

I'm working on Symfony 6.3 and "vich/uploader-bundle": "2.1.1" and the deprecations still here.

How you turn on dev-master version ?

@mdriessen
Copy link

Use "vich/uploader-bundle": "^2.1@dev" and run composer update vich/uploader-bundle.

The deprecation Method getEntityManager() is deprecated and will be removed in Doctrine ORM 3.0. Use getObjectManager() instead. still exists. But that's only when removing a file. The above deprecation triggers 4 times per request.

@endelwar
Copy link
Contributor

endelwar commented Aug 9, 2023

I can confirm no more
User Deprecated: Since symfony/doctrine-bridge 6.3: Registering "Vich\UploaderBundle\EventListener\Doctrine\UploadListener" as a Doctrine subscriber is deprecated. Register it as a listener instead, using e.g. the #[AsDoctrineListener] attribute.

on Symfony 6.3.2 with

"vich/uploader-bundle": "dev-master"

@laurentmuller
Copy link
Contributor

I have tested with Symfony 6.3.3 and the only remaining deprecation is:

User Deprecated: Method Doctrine\ORM\Event\LifecycleEventArgs::getEntityManager() is deprecated and will be removed in Doctrine ORM 3.0. Use getObjectManager() instead.

It is explained in #1393 and resolved in #1395.

@laurentmuller
Copy link
Contributor

We can use the #[AsDoctrineListener] attribute but then all listeners are registred even if the user does not require one.
See the registerListeners method on the VichUploaderExtension class.

@mdriessen
Copy link

Any reason #1395 was closed without being merged?

@garak
Copy link
Collaborator

garak commented Aug 10, 2023

Any reason #1395 was closed without being merged?

It was closed by PR author himself

@laurentmuller
Copy link
Contributor

This was a mistake from me. I have re-opened.

Sorry...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants