Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rusk-wallet: Replace test-wallet in rusk tests #2275

Open
moCello opened this issue Sep 5, 2024 · 0 comments · May be fixed by #2281
Open

rusk-wallet: Replace test-wallet in rusk tests #2275

moCello opened this issue Sep 5, 2024 · 0 comments · May be fixed by #2281
Assignees
@moCello
Labels
module:rusk-wallet Issues related to rusk wallet type:enhancement Issues concerning code or feature improvement (performance, refactoring, etc)

Comments

@moCello
Copy link
Member

moCello commented Sep 5, 2024

Summary

Test the functionalities of the rusk-wallet by plugging it into the tests of rusk.

Currently rusk used a test-wallet for its tests but that was always meant to be a temporary solution. Now that the rusk-wallet is a workspace member of rusk it makes sense to deprecate the test-wallet and use the rusk-wallet for the rusk tests.
@moCello moCello linked a pull request Sep 5, 2024 that will close this issue
Open
@HDauven HDauven mentioned this issue Sep 28, 2024
Closed
@HDauven HDauven added type:enhancement Issues concerning code or feature improvement (performance, refactoring, etc) module:rusk-wallet Issues related to rusk wallet labels Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moCello moCello

Labels
module:rusk-wallet Issues related to rusk wallet type:enhancement Issues concerning code or feature improvement (performance, refactoring, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rusk-wallet: Replace test-wallet in rusk tests dusk-network/rusk
2 participants
@HDauven @moCello