Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keys can be generated from two different CRS #825

Open
ureeves opened this issue Feb 3, 2023 · 0 comments
Open

Keys can be generated from two different CRS #825

ureeves opened this issue Feb 3, 2023 · 0 comments
Assignees
Labels
fix:bug Something isn't working need:brainstorm Call for participation: group brainstorming is requested to fix this issue priority:minor Low priority issues

Comments

@ureeves
Copy link
Member

ureeves commented Feb 3, 2023

Describe the bug
Currently 8 circuits can be compiled to produce their prover and verifier keys. For this process, a single CRS is lazily generated and cached for subsequent use. It is currently possible to generate the first few keys using make keys, cancel the process, delete the generated CRS, and happily rerun make keys. This will produce one set of keys compiled with the deleted CRS, and a set of keys compiled using the new CRS.

To Reproduce
To make this happen, follow the following process:

source .env
make keys
# wait until "Fetching SendToContractObfuscated key from cache"
# and then press Ctrl+C to interrupt the process
rm .rusk/dev.crs
make keys

Expected behaviour
We should be prevented from doing this. make keys should trigger a CRS rebuild when a different one is generated.

@ureeves ureeves added area:conf&build priority:minor Low priority issues fix:bug Something isn't working labels Feb 3, 2023
@HDauven HDauven added need:brainstorm Call for participation: group brainstorming is requested to fix this issue and removed area:conf&build labels Apr 8, 2024
@HDauven HDauven added this to the Mainnet milestone Apr 9, 2024
@HDauven HDauven self-assigned this Apr 10, 2024
@HDauven HDauven removed this from the Remaining for Mainnet milestone Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix:bug Something isn't working need:brainstorm Call for participation: group brainstorming is requested to fix this issue priority:minor Low priority issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants