Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Duolingo References from README Code Samples #14

Closed
biniona opened this issue Mar 19, 2024 · 5 comments
Closed

Remove Duolingo References from README Code Samples #14

biniona opened this issue Mar 19, 2024 · 5 comments
Labels
1.x Blocker for 1.x Release docs

Comments

@biniona
Copy link
Contributor

biniona commented Mar 19, 2024

Remove all references to Duolingo the company from README code samples.
@biniona biniona added 1.x Blocker for 1.x Release docs labels Mar 19, 2024
@xiyan128
Copy link
Contributor

8ea7dfb

Is this already resolved?

@biniona
Copy link
Contributor Author

biniona commented Jul 16, 2024

I think we should do a readthrough of the docs and just double check. Once someone double checks we should be all set.

@xiyan128
Copy link
Contributor

there are some references to duolingo_base because of outdated permalinks pointing to previous commits of code examples.

e.g. https://github.com/duolingo/minject/blob/master/docs/dependency_injection.md

saw is this a known issue #25 not tagged 1.x.

@biniona
Copy link
Contributor Author

biniona commented Jul 16, 2024

I think that is included in #14 ^

@xiyan128 xiyan128 mentioned this issue Jul 16, 2024
Merged
@xiyan128
Copy link
Contributor

resolved by #31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.x Blocker for 1.x Release docs
Milestone
No milestone
Development

No branches or pull requests
2 participants
@biniona @xiyan128