Skip to content

stack tag notifications do not use the new icon #1471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mortezadadgar opened this issue Apr 19, 2025 · 7 comments · May be fixed by #1473
Open

stack tag notifications do not use the new icon #1471

mortezadadgar opened this issue Apr 19, 2025 · 7 comments · May be fixed by #1473

Comments

@mortezadadgar
Copy link

mortezadadgar commented Apr 19, 2025

Hey,
basically if the provided icon of a icon file is updated next notifications will use the old icon

How to reproduce

  1. no change to config is needed
  2. use a file as a example for icon file and run:
$ notify-send -h string:x-dunst-stack-tag:test -i tmp.jpg "123"
  1. change the tmp.jpg file
  2. as long as the last notification is visible on screen run the same command for sending notification and see the previous icon is shown

System information

dunst version: 1.12.2 (2025-03-05)
Linux distro: Archlinux

@bynect
Copy link
Member

bynect commented Apr 19, 2025

Hello thanks for pointing this out. Is this a regression or was this introduced in the new dunst version? Also does notify-send beahve differently than dunstify?

@mortezadadgar
Copy link
Author

@bynect I don't know it's a regression just recently find out about stack tag and notify-send and dunstify behave similarly

@bynect
Copy link
Member

bynect commented Apr 28, 2025

I can reproduce this issue. it is very strange that it happens only when the stack tag is set. I will investigate

@bynect
Copy link
Member

bynect commented Apr 28, 2025

it seems to be caused by the way that tagged notifications are treated, which is different than normal duplicates

@bynect
Copy link
Member

bynect commented Apr 30, 2025

I found the cause. it is in the way icons are compared that checks just the path name. I will try to come up with a solution without compromising performance

@bynect bynect linked a pull request Apr 30, 2025 that will close this issue
@bynect
Copy link
Member

bynect commented Apr 30, 2025

if you want to try I changed the way duplicate icons are checked in #1473

@mnpqraven
Copy link

mnpqraven commented May 15, 2025

if you want to try I changed the way duplicate icons are checked in #1473

I'm trying this PR out and can confirm new icons are replaced correctly
this is the script being used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants