Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve ~ or $HOME in icon_path #1371

Closed
danielwerg opened this issue Aug 19, 2024 · 4 comments · Fixed by #1383
Closed

Resolve ~ or $HOME in icon_path #1371

danielwerg opened this issue Aug 19, 2024 · 4 comments · Fixed by #1383

Comments

@danielwerg
Copy link

danielwerg commented Aug 19, 2024 •
edited
Loading

Issue description

dunst doesn't resolve ~ or $HOME in icon_path. It was claimed to be fixed in 1.4 by @tsipinakis and here by @bebehei so I'm little puzzled.

Installation info

  • Version: 1.11.0 (2024-04-15)
  • Install type: package
  • Window manager / Desktop environment: Hyprland
  • Distro: Artix
Minimal dunstrc 
enable_recursive_icon_lookup = false
# doesn't work
icon_path = ~/.config/dunst/icons/
# also doesn't work
#icon_path = $HOME/.config/dunst/icons/
# works
#icon_path = /home/<USER>/.config/dunst/icons/

Related: #350 #520
@bebehei
Copy link
Member

bebehei commented Aug 19, 2024

Is this a regression?

@danielwerg
Copy link
Author

Is this a regression?

I haven't edited dunst config before so not sure.

@bynect
Copy link
Member

bynect commented Aug 20, 2024

I'm not sure if this is a regression. the problem seems to lie here

dunst/src/icon.c

Line 241 in 844167a

do {

I will try to add the recognition of ~

@zappolowski zappolowski mentioned this issue Sep 23, 2024
Merged
@zappolowski
Copy link
Member

@danielwerg could you try #1383?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resolve ~ and $HOME in icon_path zappolowski/dunst
4 participants
@bebehei @zappolowski @danielwerg @bynect