Skip to content

Commit a234921

Browse files
committed
Fix install test
1 parent bda7e86 commit a234921

File tree

4 files changed

+37
-25
lines changed

4 files changed

+37
-25
lines changed

.github/workflows/main.yml

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,10 @@ jobs:
7474
CC: gcc
7575
EXTRA_CFLAGS: "-Werror"
7676
MAKE: gmake
77+
INSTALL: ginstall
78+
FIND: gfind
79+
SED: gsed
80+
AWK: gawk
7781

7882
steps:
7983
- uses: actions/checkout@v4
@@ -83,18 +87,22 @@ jobs:
8387
- name: Test in FreeBSD
8488
uses: vmactions/freebsd-vm@v1
8589
with:
86-
envs: "CC EXTRA_CFLAGS MAKE"
90+
envs: "CC EXTRA_CFLAGS MAKE INSTALL FIND SED AWK"
8791
usesh: true
8892
sync: rsync
8993
copyback: false
9094

9195
prepare: |
9296
pkg install -y x11-toolkits/pango devel/glib20 graphics/gdk-pixbuf2 graphics/cairo graphics/wayland \
9397
devel/libnotify devel/dbus x11/libXScrnSaver x11/libXrandr x11/libXext x11/libX11 lang/perl5.36 \
94-
devel/pkgconf devel/gmake devel/evdev-proto valgrind x11/libXinerama graphics/wayland-protocols \
95-
devel/gettext-runtime x11-fonts/fontconfig x11-fonts/dejavu lang/gcc git librsvg2 bash
98+
devel/pkgconf devel/evdev-proto valgrind x11/libXinerama graphics/wayland-protocols \
99+
devel/gettext-runtime x11-fonts/dejavu lang/gcc git librsvg2 bash findutils coreutils gmake
96100
97101
run: |
102+
echo "* Info"
103+
ls -la
104+
git describe --tags
105+
98106
echo "* Run test suite"
99107
gmake -j test
100108

.valgrind.suppressions

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,6 @@
218218
# FreeBSD part1
219219
glib_leak_freebsd1
220220
Memchek:Leak
221-
fun:*alloc
222221
...
223222
fun:g_dbus_address_get_stream_sync
224223
...
@@ -229,7 +228,6 @@
229228
# XXX: Why isn't memory freed in g_bus_unown_name?
230229
glib_leak_freebsd2
231230
Memchek:Leak
232-
fun:*alloc
233231
...
234232
fun:g_bus_own_name
235233
...

Makefile

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ endif
9494
test: test/test clean-coverage-run
9595
# Make sure an error code is returned when the test fails
9696
/usr/bin/env bash -c 'set -euo pipefail;\
97-
TESTDIR=./test ./test/test -v | ./test/greenest.awk '
97+
TESTDIR=./test ./test/test -v | ${AWK} -f ./test/greenest.awk '
9898

9999
test-valgrind: test/test
100100
TESTDIR=./test ${VALGRIND} \
@@ -223,49 +223,49 @@ clean-wayland-protocols:
223223
install: install-dunst install-dunstctl install-dunstrc install-service
224224

225225
install-dunst: dunst doc
226-
install -Dm755 dunst ${DESTDIR}${BINDIR}/dunst
227-
install -Dm644 docs/dunst.1 ${DESTDIR}${MANPREFIX}/man1/dunst.1
228-
install -Dm644 docs/dunst.5 ${DESTDIR}${MANPREFIX}/man5/dunst.5
229-
install -Dm644 docs/dunstctl.1 ${DESTDIR}${MANPREFIX}/man1/dunstctl.1
230-
install -Dm644 docs/dunstify.1 ${DESTDIR}${MANPREFIX}/man1/dunstify.1
226+
${INSTALL} -Dm755 dunst ${DESTDIR}${BINDIR}/dunst
227+
${INSTALL} -Dm644 docs/dunst.1 ${DESTDIR}${MANPREFIX}/man1/dunst.1
228+
${INSTALL} -Dm644 docs/dunst.5 ${DESTDIR}${MANPREFIX}/man5/dunst.5
229+
${INSTALL} -Dm644 docs/dunstctl.1 ${DESTDIR}${MANPREFIX}/man1/dunstctl.1
230+
${INSTALL} -Dm644 docs/dunstify.1 ${DESTDIR}${MANPREFIX}/man1/dunstify.1
231231

232232
install-dunstctl: dunstctl
233-
install -Dm755 dunstctl ${DESTDIR}${BINDIR}/dunstctl
233+
${INSTALL} -Dm755 dunstctl ${DESTDIR}${BINDIR}/dunstctl
234234

235235
ifeq (1,${SYSCONF_FORCE_NEW})
236236
install-dunstrc:
237-
install -Dm644 dunstrc ${DESTDIR}${SYSCONFFILE}
237+
${INSTALL} -Dm644 dunstrc ${DESTDIR}${SYSCONFFILE}
238238
endif
239239

240240
install-service: install-service-dbus
241241
install-service-dbus: service-dbus
242-
install -Dm644 org.knopwob.dunst.service ${DESTDIR}${SERVICEDIR_DBUS}/org.knopwob.dunst.service
242+
${INSTALL} -Dm644 org.knopwob.dunst.service ${DESTDIR}${SERVICEDIR_DBUS}/org.knopwob.dunst.service
243243
ifneq (0,${SYSTEMD})
244244
install-service: install-service-systemd
245245
install-service-systemd: service-systemd
246-
install -Dm644 dunst.systemd.service ${DESTDIR}${SERVICEDIR_SYSTEMD}/dunst.service
246+
${INSTALL} -Dm644 dunst.systemd.service ${DESTDIR}${SERVICEDIR_SYSTEMD}/dunst.service
247247
endif
248248

249249
ifneq (0,${DUNSTIFY})
250250
install: install-dunstify
251251
install-dunstify: dunstify
252-
install -Dm755 dunstify ${DESTDIR}${BINDIR}/dunstify
252+
${INSTALL} -Dm755 dunstify ${DESTDIR}${BINDIR}/dunstify
253253
endif
254254

255255
ifneq (0,${COMPLETIONS})
256256
install: install-completions
257257
install-completions:
258-
install -Dm644 completions/dunst.bashcomp ${DESTDIR}${BASHCOMPLETIONDIR}/dunst
259-
install -Dm644 completions/dunstctl.bashcomp ${DESTDIR}${BASHCOMPLETIONDIR}/dunstctl
260-
install -Dm644 completions/_dunst.zshcomp ${DESTDIR}${ZSHCOMPLETIONDIR}/_dunst
261-
install -Dm644 completions/_dunstctl.zshcomp ${DESTDIR}${ZSHCOMPLETIONDIR}/_dunstctl
262-
install -Dm644 completions/dunst.fishcomp ${DESTDIR}${FISHCOMPLETIONDIR}/dunst.fish
263-
install -Dm644 completions/dunstctl.fishcomp ${DESTDIR}${FISHCOMPLETIONDIR}/dunstctl.fish
258+
${INSTALL} -Dm644 completions/dunst.bashcomp ${DESTDIR}${BASHCOMPLETIONDIR}/dunst
259+
${INSTALL} -Dm644 completions/dunstctl.bashcomp ${DESTDIR}${BASHCOMPLETIONDIR}/dunstctl
260+
${INSTALL} -Dm644 completions/_dunst.zshcomp ${DESTDIR}${ZSHCOMPLETIONDIR}/_dunst
261+
${INSTALL} -Dm644 completions/_dunstctl.zshcomp ${DESTDIR}${ZSHCOMPLETIONDIR}/_dunstctl
262+
${INSTALL} -Dm644 completions/dunst.fishcomp ${DESTDIR}${FISHCOMPLETIONDIR}/dunst.fish
263+
${INSTALL} -Dm644 completions/dunstctl.fishcomp ${DESTDIR}${FISHCOMPLETIONDIR}/dunstctl.fish
264264

265265
ifneq (0,${DUNSTIFY})
266266
install: install-completions-dunstify
267267
install-completions-dunstify:
268-
install -Dm644 completions/dunstify.fishcomp ${DESTDIR}${FISHCOMPLETIONDIR}/dunstify.fish
268+
${INSTALL} -Dm644 completions/dunstify.fishcomp ${DESTDIR}${FISHCOMPLETIONDIR}/dunstify.fish
269269
endif
270270
endif
271271

config.mk

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,21 @@ SERVICEDIR_SYSTEMD ?= ${PREFIX}/lib/systemd/user
1515
EXTRA_CFLAGS ?=
1616

1717
DOXYGEN ?= doxygen
18-
FIND ?= find
1918
GCOVR ?= gcovr
2019
GIT ?= git
2120
PKG_CONFIG ?= pkg-config
2221
POD2MAN ?= pod2man
23-
SED ?= sed
2422
SYSTEMDAEMON ?= systemd
2523
VALGRIND ?= valgrind
2624

25+
# Provided for compatibility with BSDs
26+
# You will need to prepend g's to these programs
27+
INSTALL ?= install
28+
MAKE ?= make
29+
FIND ?= find
30+
SED ?= sed
31+
AWK ?= awk
32+
2733
# Disable systemd service file installation,
2834
# if you don't want to use systemd albeit installed
2935
#SYSTEMD ?= 0

0 commit comments

Comments
 (0)