Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Meson #9

Open
apprehensions opened this issue Jan 25, 2024 · 2 comments
Open

Add Meson #9

apprehensions opened this issue Jan 25, 2024 · 2 comments

Comments

@apprehensions
Copy link

apprehensions commented Jan 25, 2024

For adding multiple distros as seen on dunst-project/dunst#1226

Personally, i do not understand the reason for such complicated build systems, if one can do something like Sway does: https://github.com/swaywm/sway/tree/master/.builds which is have only builds for alpine and arch, in a very simple CI manner.

@fwsmit
Copy link
Member

fwsmit commented Jan 25, 2024

This was discussed a bit already in dunst-project/dunst#1226 (comment). I do see value in having some more distro's in there. @bebehei do you have thoughts on this?

@bebehei
Copy link
Member

bebehei commented Mar 3, 2024

The docker-images repository just exists to have pre-built docker images, which do not require package installation for every pipeline and just use the pre-assembled one.

At the end, this speeds up the overall build time.

Back in 2018 we also used Travis CI, which was horribly slow on top. So having a full repo, which runs the CI pipeline locally without the need to do a full checkin was also a huge benefit. Running the full pipeline on my own desktop machine was a matter of ca. 15 seconds.

I guess the swaywm buildsystem (IIRC it's sourcehut) has an optimisation for the package parameter, otherwise this will take a lot of time, too.


I agree, this might not be the best solution anymore. I also see, that it's a bit of an overkill, having 10 different DISTROS (not even different OSes like Linux/BSD etc.) in our CI. IMO we had enough cases justifying, that we test for different distros. There are common mistakes regarding differnt include paths, etc.


To add meson support, you just need to add the relevant meson packages into the Dockerfiles here:

https://github.com/dunst-project/docker-images/tree/master/ci

Afterwards the CI should pick up the changes easily (when #10 is implemented) and the dunst CI should use the images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants