Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.2.5 Not expanding (some?) Caddy's variables #1016

Closed
Simbiat opened this issue Sep 3, 2024 · 1 comment · Fixed by #1018
Closed

1.2.5 Not expanding (some?) Caddy's variables #1016

Simbiat opened this issue Sep 3, 2024 · 1 comment · Fixed by #1018
Labels
bug Something isn't working

Comments

@Simbiat
Copy link

Simbiat commented Sep 3, 2024

What happened?

Updated to 1.2.5, and now looks like Caddy variables from config are not being expanded. Or at least some of them are not.
I am using this dockerfile with these Caddy settings, which should result in CADDY_HTTP_ERROR (and CADDY_HTTP_ERROR_MSG) variables sent to PHP to be 403 (and interruption triggered) when accessing .htaccess (as example), but on 1.2.5 I am getting {http.error.status_code} (and {http.error.message}) instead. Revert back to 1.2.4 - works as expected.

Build Type

Docker (Debian Bookworm)

Worker Mode

No

Operating System

GNU/Linux

CPU Architecture

x86_64

PHP configuration

N/A (or refer https://github.com/Simbiat/simbiat.ru/blob/master/config/frankenphp/php.ini)

Relevant log output

No response

@dunglas
Copy link
Owner

dunglas commented Sep 3, 2024

I optimized this part in #1002. I probably introduced a bug in this patch. I'll take a look when I'll be back from vacation (if someone find and solve the issue before, don't hesitate to open a PR).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants