Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CoW Protocol] Remove duplicate entries for Laita solver #7567

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

bram-vdberg
Copy link
Contributor

Description:

This PR removes a duplicate entry for the Laita solver on Arbitrum prod and barn.

@github-actions github-actions bot added WIP work in progress dbt: hourly covers the hourly dbt subproject labels Jan 27, 2025
@bram-vdberg bram-vdberg marked this pull request as ready for review January 27, 2025 10:37
@github-actions github-actions bot added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Jan 27, 2025
@harisang
Copy link
Contributor

@jeff-dude Would appreciate a quick review of this as the issue (which was our fault) is creating some annoying duplicate entries in some places. Thanks a lot!

Copy link
Member

@jeff-dude jeff-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

highly suggest applying a unique test on address column in the schema yml file, if not done so already. it would catch for ya in CI runs 🙏

@jeff-dude jeff-dude self-assigned this Jan 27, 2025
@jeff-dude jeff-dude added ready-for-merging and removed ready-for-review this PR development is complete, please review labels Jan 27, 2025
@jeff-dude jeff-dude merged commit 43c99c4 into duneanalytics:main Jan 27, 2025
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dbt: hourly covers the hourly dbt subproject ready-for-merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants