-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duffel Seat component - Markup issue #234
Comments
Hey @hunainkapadia, thanks for reporting this. We'll take a look into it and come back here if we need some more info or when it's resolved. |
Hello, I wonder when this issue will be fixed. I also face this but I use My website has page A and page B. The ancillaries component is on page B. On page A, there is a button that will call This problem only occurs in seat service. It doesn't occur in baggage service. |
@xiaolinforce, @hunainkapadia. Sorry for the long delay on responding to this issue. I have tried reproducing it with no success. Could you please share a codesandbox with the issue? That'll give me a better understanding of what's going on. |
@hunainkapadia @igorp1 I know why sometimes it shows correctly, sometimes it does not, but it might be only for my case. I use this component by inputting |
Describe the bug
When you add a markup amount to the seats component, it shows 2 prices in the pop-up. One with the markup and one without. This is happening in the duffel test env on the duffel airways flight. Offer ID orq_0000AeSeP38z2qRDUirPhQ.
Version of @duffel/components
Please add:
Code sample to reproduce
duffelAncillariesElement.render({
debug:true,
offer_id: "{{ offer.id }}",
client_key: "{{ flight_search.client_key }}",
services: ["seats"],
passengers: extras_passengers,
markup: {
seats: {
amount: 2, // Add 2.00 to the price of each seat
rate: 0, // Don't add any percentage markup
}
},
styles: {
accentColor: "128,186,39",
buttonCornerRadius: "8px",
fontFamily: "OpenSans, sans-serif",
}
});
Expected behavior
When seat is selected, both prices shown to the customer will be with the markup
Screenshots
The text was updated successfully, but these errors were encountered: