Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Export for ComponentClientKeys.ts in src/booking/index.ts #998

Open
Mohit-Netzoptimize opened this issue Jan 14, 2025 · 1 comment

Comments

@Mohit-Netzoptimize
Copy link

The ComponentClientKeys.ts file is not being exported in src/booking/index.ts, which prevents accessing duffel.componentClientKeys.create(). This is causing issues when trying to use the functionality provided by ComponentClientKeys.

Currently, the src/booking/index.ts file exports the following:

export * from './AirlineInitiatedChanges';
export * from './OfferRequests';
export * from './Offers';
export * from './OrderCancellations';
export * from './Orders';
export * from './OrderChangeRequests';
export * from './OrderChangeOffers';
export * from './OrderChanges';
export * from './Payments';
export * from './PartialOfferRequests';
export * from './SeatMaps';

However, ComponentClientKeys.ts is located in src/booking/Identity/ComponentClientKey and is not included in the exports. Additionally, there is no index.ts file in the src/booking/Identity/ folder that exports ComponentClientKeys.ts.

Steps to Reproduce
Try to access duffel.componentClientKeys.create() in the current implementation.
Observe that it is inaccessible due to the missing export.

Expected Behavior
duffel.componentClientKeys.create() should be accessible after exporting ComponentClientKeys.ts in src/booking/index.ts or adding an index.ts in the src/booking/Identity/ folder to re-export ComponentClientKeys.ts.

@andrejak
Copy link
Contributor

Thank you for reporting! We accept contributions, would you be able to submit a PR with adding the export to src/booking/index.ts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants