Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CookieFirst CMP #129

Open
muodov opened this issue Apr 6, 2023 · 4 comments
Open

CookieFirst CMP #129

muodov opened this issue Apr 6, 2023 · 4 comments
Labels
CMP enhancement New feature or request

Comments

@muodov
Copy link
Member

muodov commented Apr 6, 2023

Description

We should add support for https://cookiefirst.com/

Example sites (may be outdated)

https://www.bugatti-fashion.com/en/

@kunalvirk
Copy link
Contributor

Hi,

Can I pick this up and implement CookieFirst?

Thanks

@muodov
Copy link
Member Author

muodov commented May 24, 2023

@kunalvirk sure, go ahead! Here's some tips for you:

  • Find several examples of the CMP, preferably different variations of the pop-up
    • To find more examples, try searching PublicWWW or BuiltWith
    • navigating to the vendor's own website is also a good idea
  • If you have a VPN, check if the pop-up looks different from multiple regions (at least EU and US)
  • Create a new rule JSON file
    • First, fill in prehideSelectors, detectCmp, and detectPopup
    • Rebuild the extension (with logs on) and test if it works on all those example pages:
      • correctly detects a CMP when popup is open
      • does NOT detect an open popup after it's dismissed!
    • Then, figure out steps for optOut
      • Test again that it works on all example pages
      • Finally, find a way to verify that opt-out has worked and fill in the test section. Usually it is possible by matching document.cookie
    • Test the whole flow again
    • Add a .spec.ts test file including URLs of all different variations of the CMP

@kunalvirk
Copy link
Contributor

Thanks @muodov for the tips, will pick this up and update here shortly.

@kunalvirk
Copy link
Contributor

Hi @muodov,

I have added the rule for cookiefirst and tested on few sites. Tested it as per your suggested steps and looks like this is working fine. Here is the commit: kunalvirk@a411d17

Please check if this looks good or it needs any improvement.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMP enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants