Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate validation scripts to .gitignore but make them still recognizable for GitHub Actions #89

Open
aaronjae22 opened this issue Jan 3, 2025 · 3 comments

Comments

@aaronjae22
Copy link
Collaborator

aaronjae22 commented Jan 3, 2025

The issue was created for brief discussion, it's not something we need to do now or have planned, but won't there be any problem in the future with having our validation scripts public?

@aaronjae22 aaronjae22 self-assigned this Jan 3, 2025
@lisad
Copy link
Member

lisad commented Jan 3, 2025

On reflection, I'm not sure this is possible. If they're in .gitignore, then changes to the scripts on the developers machine would not get uploaded to github.

What's the problem we're trying to solve - what's the annoyance or bug?

@aaronjae22
Copy link
Collaborator Author

Yes, absolutely. It's kind of an annoyance. For now I don't think it's something we need to deal with because we're often making changes to our scripts, but at some point, we may change our minds. In a given case, we can store our scripts in a bucket or as GitHub Secret Actions (just like environment variables) and from there, the scripts for the corresponding validations can be obtained.

@aaronjae22
Copy link
Collaborator Author

I didn't intend to add the issue as a ticket, but I can leave the issue open and remove it from the backlog in case we eventually come up with something regarding this.

@aaronjae22 aaronjae22 removed their assignment Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants