Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation typos in GAM formula #262

Open
pjk645-zz opened this issue Mar 8, 2020 · 2 comments
Open

Documentation typos in GAM formula #262

pjk645-zz opened this issue Mar 8, 2020 · 2 comments

Comments

@pjk645-zz
Copy link

There are several instances where the functional form is shown as
$$\beta_0 + f_1(X_1) + f_2(X_2, X3) + \ldots + f_M(X_N),$$
and I believe it should be
$$\beta_0 + f_1(X_1) + f_2(X_2) + f_3( X_3) + \ldots + f_M(X_M),$$
or even this
$$\beta_0 + f_1(X_1) +\ldots + f_M(X_M)$$
is probably sufficient.

@pjk645-zz
Copy link
Author

From the pull request #263:

I changed the formulas to be single variable functions. I'm not sure if the previous intent was to imply the existence of the two variable 'tensor' functions. If that is in fact the case, then separating the two variable functions out from the single variable would be easier to read:
$$\beta_0 + f_1(X_1) + \ldots + f_M(X_M) + \sum_{j=0}^{M} \sum_{k\neq j} f_{j,k}(X_j, X_k)$$
where the double indices imply the dependance on two variables. It should also probably be mentioned that having the two variable functionality is generalizing beyond your typical GAM, which I believe are only supposed to be single variable functions

@shyamcody
Copy link

I think the two-variable dependence essentially points out the existence of the tensor terms. So maybe it's not that of a typo to fix in that sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants