Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring relation and fact schema #18

Open
lintool opened this issue Sep 27, 2019 · 3 comments
Open

Refactoring relation and fact schema #18

lintool opened this issue Sep 27, 2019 · 3 comments

Comments

@lintool
Copy link
Member

lintool commented Sep 27, 2019

Currently, our schema for relations and facts looks something like this:

Screen Shot 2019-09-27 at 5 37 56 AM

There's an asymmetry here, as relations are reified with an explicit relation node. We should refactor to make more consistent.

(also, to me, object_of relation has the directionality reversed)

@ryan-clancy
Copy link
Member

In introducing an intermediate relation node for the ground-truth, do we want the type to be CITY_OF_HEADQUARTERS (CoreNLP) or P159 (Wikidata)?

An argument for CITY_OF_HEADQUARTERS is that the queries are cleaner as we can match on nodes of the same type, but against would be that we lose the Wikidata property information (does this even matter?).

An argument for P159 is that we maintain the Wikidata property and can map back and see where it came from, but the queries are messier because we need to know, and include, the mapping between CoreNLP <-> Wikidata.

@lintool
Copy link
Member Author

lintool commented Sep 27, 2019

I'm leaning to P159. This leaves open the possibility that a relation might not align perfectly with a fact property, so we can't do this mapping up front.

So, just to be concrete, the tweak we are suggesting is to take fact (Q355 "Facebook", hq, Q74195 "Menlo Park") and create:

  • (Q355, subject-of, FACT[type:hq])
  • (Q74195, object-of, FACT[type:hq])

This also allows the mention "Menlo Park" in text to be linked to Q74195.

@lintool
Copy link
Member Author

lintool commented Sep 27, 2019

And furthermore, I would change to has-subject and has-object to make sure that it is obvious that the FACT or RELATION should be in the first place in the triple.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants