Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocorrect to add check to configuration does not put string params in quotes #51

Open
GrahamPearsonAvaloq opened this issue Feb 6, 2018 · 0 comments
Assignees

Comments

@GrahamPearsonAvaloq
Copy link
Member

Actual Result:

check configuration name {
catalog com.mycompany.it.sca.scripting.ScriptingChecksCatalog {
default ParameterNameLacksPrefix (prefix = i_)
}
}
Error:
no viable alternative at input 'i_'

Expected Result:

check configuration name {
catalog com.mycompany.it.sca.scripting.ScriptingChecksCatalog {
default ParameterNameLacksPrefix (prefix = "i_")
}
}

Steps to Reproduce:

Deploy the following check:
live warning ParameterNameLacksPrefix "Parameter name lacks prefix" (String prefix = "i_")
message "Parameter name {0} must start with {1}"
{
}

Create the following check configuration:
check configuration name {
catalog com.mycompany.it.sca.scripting.ScriptingChecksCatalog {

}
}

In the check configuration, use autocomplete to add the check.

GrahamPearsonAvaloq added a commit to GrahamPearsonAvaloq/dsl-devkit that referenced this issue Feb 6, 2018
…string

params in quotes

Autocorrect to add check to configuration now does put string params in
quotes.
It also now handles default string parameters containing whitespace;
previously it did not.

Issue-Id: dsldevkit#44
GrahamPearsonAvaloq added a commit to GrahamPearsonAvaloq/dsl-devkit that referenced this issue Feb 6, 2018
…string

params in quotes

Autocorrect to add check to configuration now does put string params in
quotes.
It also now handles default string parameters containing whitespace;
previously it did not.

Issue-Id: dsldevkit#51
@GrahamPearsonAvaloq GrahamPearsonAvaloq self-assigned this Feb 6, 2018
GrahamPearsonAvaloq added a commit to GrahamPearsonAvaloq/dsl-devkit that referenced this issue Feb 6, 2018
…string

params in quotes

Autocorrect to add check to configuration now does put string params in
quotes.
It also now handles default string parameters containing whitespace;
previously it did not.
Also stopped the "Add all registered catalogs" template listing all
their checks (without parameters).

Issue-Id: dsldevkit#51
GrahamPearsonAvaloq added a commit to GrahamPearsonAvaloq/dsl-devkit that referenced this issue Feb 12, 2018
…string

params in quotes

* Extract the code for creating a literal-value template pattern from
CheckCfgTemplateProposalProvider into a new helper,
TemplateProposalProviderHelper, where it can be unit tested.
* Avoid getting a JvmType representation of String just to check the
type of a Check parameter.
* CheckConfiguration template now gets the check configuration name from
the filename instead of using hardwired value "name".
* Move ResourceNameTemplateVariableResolver from ddk.check.ui to
ddk.xtext.ui so CheckCfgTemplateProposalProvider can use it. Changed its
'catalog' parameter value to 'file' to better reflect its meaning.
* Add unit tests for
** ResourceNameTemplateVariableResolver (only when resolving a filename;
resolving a package name looks much less testable and hasn't been
touched)
** SimpleEnumTemplateVariableResolver
** TemplateProposalProviderHelper

Issue-Id: dsldevkit#51
GrahamPearsonAvaloq added a commit to GrahamPearsonAvaloq/dsl-devkit that referenced this issue Feb 12, 2018
…string

params in quotes

* Extract the code for creating a literal-value template pattern from
CheckCfgTemplateProposalProvider into a new helper,
TemplateProposalProviderHelper, where it can be unit tested.
* Avoid getting a JvmType representation of String just to check the
type of a Check parameter.
* CheckConfiguration template now gets the check configuration name from
the filename instead of using hardwired value "name".
* Move ResourceNameTemplateVariableResolver from ddk.check.ui to
ddk.xtext.ui so CheckCfgTemplateProposalProvider can use it. Changed its
'catalog' parameter value to 'file' to better reflect its meaning.
* Add unit tests for
** ResourceNameTemplateVariableResolver (only when resolving a filename;
resolving a package name looks much less testable and hasn't been
touched)
** SimpleEnumTemplateVariableResolver
** TemplateProposalProviderHelper

Issue-Id: dsldevkit#51
GrahamPearsonAvaloq added a commit to GrahamPearsonAvaloq/dsl-devkit that referenced this issue Feb 13, 2018
…string

params in quotes

Use fully-qualified names in some Javadoc to avoid importing the
referenced classes.
Revert line endings in xtext.ui's manifest to LF.
Change line endings in xtext.ui.test's manifest (which is only a few
weeks old) to LF for consistency.

Issue-Id: dsldevkit#51
GrahamPearsonAvaloq added a commit to GrahamPearsonAvaloq/dsl-devkit that referenced this issue Feb 14, 2018
…string

params in quotes

Do not display fully-qualified names in some Javadoc.
Revert line endings in xtext.test.ui's manifest to CRLF.

Issue-Id: dsldevkit#51
GrahamPearsonAvaloq added a commit to GrahamPearsonAvaloq/dsl-devkit that referenced this issue Feb 15, 2018
…string

params in quotes

* Use @BeforeAll and @afterall instead of @BeforeClass and @afterclass.
* Remove SimpleEnumTemplateVariableResolverTest.testResolveValuesWithNoParams().
  Since TemplateVariableType cannot be mocked, and TemplateVariable
  cannot be created with 0 values, this test case is untestable.
* Add missing @throws documentation to
  TemplateVariableResolverTestHelper.createTemplateVariable().
* XtextUiTestSuite.launch now runs tests in alphanumeric order to match
  the order used by Maven, to make it easier to reproduce failures
  locally.

Issue-Id: dsldevkit#51
GrahamPearsonAvaloq added a commit that referenced this issue Feb 20, 2018
#51: Autocorrect to add check to configuration does not put string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant