Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged streams make it unable to access streams #193

Open
WoLfulus opened this issue Nov 28, 2023 · 1 comment
Open

Merged streams make it unable to access streams #193

WoLfulus opened this issue Nov 28, 2023 · 1 comment

Comments

@WoLfulus
Copy link

I'm not sure if this is intended or not, but enabling captureCombined will make getBuffers return CapturingBufferWriter for both stdout and stderr instead of PipedBuffer. The problem is that when calling the constructor of CommandChild, it checks against instances of PipedBuffer only, making it pass undefined to both buffers and making any call to CommandChild.{stdout,stderr}() fail in the assertion function.

I was expecting to be able to access the streams even when I wanted a combined buffer too.

@dsherret
Copy link
Owner

Sorry, can you say on a higher level what the issue is when using the API (not about what's going on internally because it's changing a lot) and maybe provide an example of some code erroring?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants