Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a counter for the number of profile cards in the website #1

Open
Ninjavin opened this issue Sep 20, 2020 · 18 comments
Open

Add a counter for the number of profile cards in the website #1

Ninjavin opened this issue Sep 20, 2020 · 18 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@Ninjavin
Copy link
Collaborator

Include a sticky counter in the bottom right which shows the number of profile cards in the website.

@Ninjavin Ninjavin added enhancement New feature or request good first issue Good for newcomers hacktoberfest labels Sep 20, 2020
@VaibhaveS
Copy link

Hey, can you assign me this issue?

@aditimaurya
Copy link

Hey! I would like to work on this if you haven't assign this issue to anyone. Can you please provide me with more details regarding the issue ?

@Ninjavin
Copy link
Collaborator Author

Hey @VaibhaveS and @aditimaurya thank you for showing interest in resolving the issue. As it is reserved for Hacktoberfest, claim it after 1st October.

@VaibhaveS
Copy link

@Ninjavin you can assign the issue whenever you want, we can do a PR after OCT 1.

@aditimaurya
Copy link

@Ninjavin yeah, you can assign this issue to any one of us because hacktoberfest is on the way and it would be good if you assign this as soon as possible. We will make our PR'S after that.

@Ninjavin
Copy link
Collaborator Author

@aditimaurya I am assigning this issue to you. https://www.figma.com/file/88M7Vx2bWgJ3eUdNO12NxE/Untitled?node-id=0%3A1
This wil give you an idea of the counter I want. You may improvise it, and do the needful changes.

@Ninjavin Ninjavin assigned Ninjavin and aditimaurya and unassigned Ninjavin Sep 24, 2020
@aditimaurya
Copy link

okay sure. I'll be looking into this issue. Thanks @Ninjavin

@aditimaurya
Copy link

@Ninjavin can I fork this repo and start making changes? I'll make a PR in October, will it be fine?

@Ninjavin
Copy link
Collaborator Author

Yes @aditimaurya . Definitely.

@ommiy2j
Copy link

ommiy2j commented Sep 24, 2020

can you assign me this issue.......

@CodeHermyt
Copy link

Hey @Ninjavin ! Can you assign this issue to me?

@peekaboo5149
Copy link

Hi @Ninjavin can you pls assign me this issue

@diksha0399
Copy link

hi, @Ninjavin , i want to contribute to this repo, so please could you assign me this issue.

@VaibhaveS
Copy link

@diksha0399 it has already been assigned to @aditimaurya

@Ninjavin
Copy link
Collaborator Author

@ommiy2j @rajayushGithub @peekaboo5149 @diksha0399
The issue is currently assigned to @aditimaurya
You may create new issues you want to work on

@aditimaurya
Copy link

aditimaurya commented Sep 29, 2020

@Ninjavin is it compulsory to ad the kind of cards you have mentioned in that website? or I can modify them? Also can you please tell me in which HTML file should I make changes? there are two different files,.

@Ninjavin
Copy link
Collaborator Author

Ninjavin commented Oct 1, 2020

If you want to change the CSS, you can open a different issue and work on it. Make a separate JS file to add counter.

@aditimaurya
Copy link

@Ninjavin I/m facing some problems, could you please help me out? I am not sure whether I've to just make a separate file for the counters which is independent of the other codes (using Js ) or I have to you know, make a dependent counter which is specifically for this particular website. I mean, it's a little hard to figure out how to change the already written code and where to write my code in the large file, so could you please help me out? like please tell me on which file I need to work or I have to make a complete independent js file for the counter only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

No branches or pull requests

7 participants