Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit check for Python 3.10 in Windows #26

Open
densnow opened this issue Sep 16, 2023 · 3 comments
Open

Explicit check for Python 3.10 in Windows #26

densnow opened this issue Sep 16, 2023 · 3 comments

Comments

@densnow
Copy link
Collaborator

densnow commented Sep 16, 2023

If the instruction to install Python 3.10 is missed or ignored on a windows installation, it might not be obvious to the user (and anyone helping with troubleshooting) what the problem is. The lines "Downloading and installing M269 files..." and all that follows, plus the line "Creating Python environment $VENV... (this will take a bit)" will still be printed if user does not have Python 3.10 (As far as I can tell)

In the Unix install script we have an explicit check for Python 3.10 with a clear message and exit. Is it worth having something similar in the windows script?

@densnow
Copy link
Collaborator Author

densnow commented Sep 17, 2023

So it looks like a py -3.10 ... command will default to another (possibly latest) version if 3.10 cannot be found. The only way the script would become messy is if Python was not installed at all.

@densnow
Copy link
Collaborator Author

densnow commented Sep 21, 2023

I think this issue will be handled when #28 is dealt with, so probably should be closed?

@mwermelinger
Copy link
Member

I think these are separate issues: the activation may fail in spite of 3.10, or may succeed in spite of 3.11, so best to check both separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants