Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dialTimeout #484

Merged
merged 1 commit into from
Feb 19, 2025
Merged

fix: dialTimeout #484

merged 1 commit into from
Feb 19, 2025

Conversation

sfroment
Copy link
Member

Signed-off-by: Sacha Froment [email protected]

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Related Issues and PRs

  • Related: #
  • Closes: #

Added/updated tests?

  • Yes
  • No, because why: justify why you didn't add tests
  • I need help with writing tests

Additional Info

add instructions or screenshots on what you might think is relevant or instructions on how to manually test it

[optional] Do we need to perform any post-deployment tasks?

@sfroment
fix: dialTimeout
8758e7e 
Signed-off-by: Sacha Froment <[email protected]>
@github-actions GitHub Actions
Copy link

Flamegraph.com report

flamegraph.pprof
See in flamegraph.com

Created by Flamegraph.com Github Action

@sfroment sfroment merged commit 2564d86 into main Feb 19, 2025
14 checks passed
sfroment added a commit that referenced this pull request Feb 19, 2025
@sfroment
Merge remote-tracking branch 'origin/main' into fix/duplicate-drp-call
84e480f 
* origin/main:
  fix: dialTimeout (#484)
  fix: serialization & add types pkg (#472)
  feat: deterministic topo sort using iterative dfs (#471)
  refactor(object): linearize pair semantic (#476)
  refactor: remove unuse transport (#466)
  fix: pr template (#464)
sfroment added a commit that referenced this pull request Feb 19, 2025
@sfroment
Merge remote-tracking branch 'origin/main' into fix/duplicate-drp-call
48ef774 
* origin/main:
  fix: dialTimeout (#484)
  fix: serialization & add types pkg (#472)
  feat: deterministic topo sort using iterative dfs (#471)
  refactor(object): linearize pair semantic (#476)
  refactor: remove unuse transport (#466)
  fix: pr template (#464)

Signed-off-by: Sacha Froment <[email protected]>
JanLewDev pushed a commit that referenced this pull request Feb 19, 2025
@sfroment @JanLewDev
fix: dialTimeout (#484)
cbe5f66 
Signed-off-by: Sacha Froment <[email protected]>
@winprn winprn mentioned this pull request Feb 20, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanLewDev JanLewDev JanLewDev approved these changes

@d-roak d-roak Awaiting requested review from d-roak d-roak is a code owner

@anhnd350309 anhnd350309 Awaiting requested review from anhnd350309 anhnd350309 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfroment @JanLewDev