Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] - add packages/keychain #505

Open
trungnotchung opened this issue Feb 23, 2025 · 0 comments
Open

[FEATURE] - add packages/keychain #505

trungnotchung opened this issue Feb 23, 2025 · 0 comments
Labels
feature New feature or request

Comments

@trungnotchung
Copy link
Member

Problem Description

Currently, DRPCredentialStore handles private key storage. However, in cases involving a secp256k1 key, the networkNode also needs a matching private key. Managing these keys in multiple places can lead to inconsistencies.

Proposed Solution

Add packages/keychain, and pass secp256k1PrivateKey as a constructor parameter in networkNode. Same as libp2p: https://github.com/libp2p/js-libp2p/tree/main/packages/keychain

Implementation PR

No response

Reference Issues

No response

Unresolved questions

No response

Additional Information

No response
@trungnotchung trungnotchung added the feature New feature or request label Feb 23, 2025
@d-roak d-roak added this to DRP Feb 23, 2025
@trungnotchung trungnotchung self-assigned this Feb 23, 2025
@github-project-automation github-project-automation bot moved this to 🔮 Backlog in DRP Feb 23, 2025
@trungnotchung trungnotchung removed their assignment Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@trungnotchung