Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Message handler error when DRP id is an empty string #488

Open
winprn opened this issue Feb 19, 2025 · 2 comments
Open

[BUG] - Message handler error when DRP id is an empty string #488

winprn opened this issue Feb 19, 2025 · 2 comments
Labels
bug Something isn't working priority-medium Medium priority task

Comments

@winprn
Copy link
Collaborator

winprn commented Feb 19, 2025

Description

When we join a DRP with empty id, the messages became wild and it keeps throwing errors. This should be validate to not allow creating empty id DRP

Version

latest

Reproduction URL

No response

Reproduction steps

1. Create an empty id grid DRP, by clicking the JOIN button
2. Start another node and click JOIN again
3. View the error in console

Screenshots

No response

Logs

Browsers

No response

OS

No response

@winprn winprn added the bug Something isn't working label Feb 19, 2025
@d-roak d-roak added this to DRP Feb 19, 2025
@github-project-automation github-project-automation bot moved this to 🔮 Backlog in DRP Feb 19, 2025
@hoangquocvietuet
Copy link
Contributor

We will drop the DRP id afaik so it won't happen

@d-roak
Copy link
Contributor

d-roak commented Feb 22, 2025

add this checks on #378

@d-roak d-roak added the priority-medium Medium priority task label Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority-medium Medium priority task
Projects
None yet
Development

No branches or pull requests

3 participants