Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Vertex from protobuf everywhere #151

Closed
d-roak opened this issue Sep 10, 2024 · 6 comments · Fixed by #164
Closed

Use Vertex from protobuf everywhere #151

d-roak opened this issue Sep 10, 2024 · 6 comments · Fixed by #164
Assignees
@cwkang1998
Labels
feature New feature or request

Comments

@d-roak
Copy link
Contributor

d-roak commented Sep 10, 2024

Currently in the HashGraph we have a Vertex interface, should be replaced with the protobuf definition
@d-roak d-roak added feature New feature or request good first issue labels Sep 10, 2024
@ghost ghost added this to DRP Sep 10, 2024
@github-project-automation github-project-automation bot moved this to Triage in DRP Sep 10, 2024
@CristopherAguilar10
Copy link

Hello @d-roak Can I work on this issue? I would like to help, I have knowledge in full stack and I would like to contribute. Thanks for the opportunity

@onlydustapp OnlyDustApp
Copy link

onlydustapp bot commented Sep 14, 2024

Hey @CristopherAguilar10!
Thanks for showing interest.
We've created an application for you to contribute to Topology.
Go check it out on OnlyDust!

@d-roak
Copy link
Contributor Author

d-roak commented Sep 15, 2024

Assigned! If you have any questions, feel free to join our community channels:

https://t.me/topologyfrens
https://discord.gg/GUDGzBP5mn

@d-roak
Copy link
Contributor Author

d-roak commented Sep 23, 2024

Taking the assignment. No updates for more than 1 week and other person interested

@cwkang1998
Copy link
Contributor

Would be great if I can attempt this!

@onlydustapp OnlyDustApp
Copy link

onlydustapp bot commented Sep 23, 2024

Hey @cwkang1998!
Thanks for showing interest.
We've created an application for you to contribute to Topology.
Go check it out on OnlyDust!

cwkang1998 added a commit to cwkang1998/ts-drp that referenced this issue Sep 23, 2024
@cwkang1998
refactor: reuse protobuf Vertex definition
9cf08d5 
Re-use exisiting protobuf Vertex definition for `packages/object`,
removing the need to maintain a separate TS typedef. This is done by
re-exporting the protobuf-gen typedef with the same name.

Since protobuf makes all its field optional by default since proto3, to
address the undefined warning, a few modification is done:

1. `addToFrontier` now returns a Vertex with a defined `operation`
   field.
2. `merge` now ignores vertex with an undefined operation field.
    Alternatively we can make `merge` throw or log an error when vertex
    with undefined operation is received.

Closes drp-tech#151.
@cwkang1998 cwkang1998 mentioned this issue Sep 23, 2024
Merged
@github-project-automation github-project-automation bot moved this from 🗃️ Backlog to 🏆 Done in DRP Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cwkang1998 cwkang1998

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: reuse protobuf Vertex definition cwkang1998/ts-drp
3 participants
@d-roak @cwkang1998 @CristopherAguilar10