From ff7a5b4efa27714c1c067b146cd0d0ab87c2d6cc Mon Sep 17 00:00:00 2001 From: Sacha Froment Date: Mon, 24 Feb 2025 11:35:49 +0100 Subject: [PATCH] fix(examples/grid): :bug: bug where eventListener is added multiple time chore: better setinterval Signed-off-by: Sacha Froment chore: try to fix cache Signed-off-by: Sacha Froment chore: test bench Signed-off-by: Sacha Froment chore: test bench Signed-off-by: Sacha Froment --- .github/workflows/benchmark.yml | 5 +++-- examples/grid/src/index.ts | 14 ++++++++++++-- test | 0 3 files changed, 15 insertions(+), 4 deletions(-) create mode 100644 test diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml index ee68edf7a..7fab55d3f 100644 --- a/.github/workflows/benchmark.yml +++ b/.github/workflows/benchmark.yml @@ -32,9 +32,9 @@ jobs: uses: actions/cache@v4 with: path: ./cache - key: benchmark-${{ runner.os }}-${{ github.run_id }} + key: benchmark-${{ runner.os }}-${{ github.ref }} restore-keys: | - benchmark-${{ runner.os }} + benchmark-${{ runner.os }}- - name: Store benchmark result uses: benchmark-action/github-action-benchmark@v1 @@ -50,6 +50,7 @@ jobs: gh-pages-branch: main skip-fetch-gh-pages: ${{ github.event_name == 'push' }} benchmark-data-dir-path: ./cache/benchmarks + ref: "ec5b182e486543fb2810419377774b9957a3d3ee" docs: if: github.event_name == 'push' && github.ref == 'refs/heads/main' diff --git a/examples/grid/src/index.ts b/examples/grid/src/index.ts index 6387d25ae..7061c8bf7 100644 --- a/examples/grid/src/index.ts +++ b/examples/grid/src/index.ts @@ -92,8 +92,14 @@ async function run(metrics?: IMetrics) { }); const button_connect = document.getElementById("joinGrid"); + const grid_input = document.getElementById("gridInput"); + grid_input.addEventListener("keydown", (event) => { + if (event.key === "Enter") { + button_connect.click(); + } + }); button_connect.addEventListener("click", async () => { - const drpId = (document.getElementById("gridInput")).value; + const drpId = grid_input.value; try { gridState.drpObject = await gridState.node.connectObject({ id: drpId, @@ -138,15 +144,19 @@ async function main() { metrics = new OpentelemetryMetrics("grid-service-2"); } + let hasRun = false; + const networkConfig = getNetworkConfigFromEnv(); gridState.node = new DRPNode(networkConfig ? { network_config: networkConfig } : undefined); await gridState.node.start(); await gridState.node.networkNode.isDialable(async () => { console.log("Started node", import.meta.env); + if (hasRun) return; + hasRun = true; await run(metrics); }); - setInterval(renderInfo, import.meta.env.VITE_RENDER_INFO_INTERVAL); + if (!hasRun) setInterval(renderInfo, import.meta.env.VITE_RENDER_INFO_INTERVAL); } void main(); diff --git a/test b/test new file mode 100644 index 000000000..e69de29bb