Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve exception erroring #82

Open
coxley opened this issue Mar 9, 2016 · 2 comments
Open

Improve exception erroring #82

coxley opened this issue Mar 9, 2016 · 2 comments

Comments

@coxley
Copy link
Contributor

coxley commented Mar 9, 2016

This is what an exception for an attribute not existing when creating network looks like:

pynsot.vendor.slumber.exceptions.HttpClientError: Client Error 400: https://nsot.example.com/api/sites/4/networks/

That tells me nothing. You can catch the exception and inspect .response.json(), but this should be part of our client lib. We should create our own exception types.

@jathanism
Copy link
Contributor

Just to mirror what I've shared before... If you look at pynsot.app.App, I want more of the user-friendliness to actually just be integrated into the default client, including the error-handling and helper methods.

@jathanism
Copy link
Contributor

Translation: All exceptions (400 <=> 500 error codes) should be caught, and their payloads returned...

@jathanism jathanism modified the milestone: v1.0 Apr 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants