From 87c917b4e7195ebcc07a1f0517d31577fc4a7049 Mon Sep 17 00:00:00 2001 From: Jim Sheldon Date: Thu, 22 Dec 2022 13:24:48 -0500 Subject: [PATCH 1/3] update act to v0.2.34 this also required updating the action image to node16 this is a potentially breaking change, so I don't think we want this plugin image to be tagged 'latest' if/when this change is merged to main I have also updated the drone pipeline to only publish the image on tag events, so if we give a proper tag (maybe 2.0.0) this updated plugin image will be available as plugins/github-actions:2 which will not break existing pipelines pulling latest --- .drone.yml | 14 +++++++++++++- cmd/main.go | 2 +- docker/Dockerfile.linux.amd64 | 2 +- 3 files changed, 15 insertions(+), 3 deletions(-) diff --git a/.drone.yml b/.drone.yml index f6ba18a..06db2d0 100644 --- a/.drone.yml +++ b/.drone.yml @@ -15,6 +15,15 @@ steps: - go test ./... - sh scripts/build.sh +- name: publish (dry run) + image: plugins/docker + pull: if-not-exists + settings: + dry_run: true + repo: plugins/github-actions + auto_tag: true + dockerfile: docker/Dockerfile.linux.amd64 + - name: publish image: plugins/docker pull: if-not-exists @@ -25,4 +34,7 @@ steps: username: from_secret: docker_username password: - from_secret: docker_password \ No newline at end of file + from_secret: docker_password + when: + event: + - tag \ No newline at end of file diff --git a/cmd/main.go b/cmd/main.go index 93b7be6..dfdc068 100644 --- a/cmd/main.go +++ b/cmd/main.go @@ -73,7 +73,7 @@ func main() { cli.StringFlag{ Name: "action-image", Usage: "Image to use for running github actions", - Value: "node:12-buster-slim", + Value: "node:16-buster-slim", EnvVar: "PLUGIN_ACTION_IMAGE", }, cli.StringFlag{ diff --git a/docker/Dockerfile.linux.amd64 b/docker/Dockerfile.linux.amd64 index 0380593..aee685a 100644 --- a/docker/Dockerfile.linux.amd64 +++ b/docker/Dockerfile.linux.amd64 @@ -3,7 +3,7 @@ FROM docker:dind ENV DOCKER_HOST=unix:///var/run/docker.sock RUN apk add --no-cache ca-certificates curl -RUN curl -s https://raw.githubusercontent.com/nektos/act/master/install.sh | sh -s v0.2.24 +RUN curl -s https://raw.githubusercontent.com/nektos/act/master/install.sh | sh -s v0.2.34 ADD release/linux/amd64/plugin /bin/ ENTRYPOINT ["/usr/local/bin/dockerd-entrypoint.sh", "/bin/plugin"] \ No newline at end of file From c11b39af26c7b3397839a1f47f924e8efb15283a Mon Sep 17 00:00:00 2001 From: Jim Sheldon Date: Thu, 22 Dec 2022 13:33:29 -0500 Subject: [PATCH 2/3] remove auto tag from dry run step --- .drone.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.drone.yml b/.drone.yml index 06db2d0..7b501cf 100644 --- a/.drone.yml +++ b/.drone.yml @@ -21,8 +21,9 @@ steps: settings: dry_run: true repo: plugins/github-actions - auto_tag: true dockerfile: docker/Dockerfile.linux.amd64 + tags: + - latest - name: publish image: plugins/docker @@ -37,4 +38,4 @@ steps: from_secret: docker_password when: event: - - tag \ No newline at end of file + - tag From db3f9ad9aededf77082bfab4d7ef56b26802546b Mon Sep 17 00:00:00 2001 From: Shubham Agrawal Date: Tue, 10 Jan 2023 21:32:55 +0530 Subject: [PATCH 3/3] Update .drone.yml --- .drone.yml | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/.drone.yml b/.drone.yml index 7b501cf..af5a129 100644 --- a/.drone.yml +++ b/.drone.yml @@ -15,16 +15,6 @@ steps: - go test ./... - sh scripts/build.sh -- name: publish (dry run) - image: plugins/docker - pull: if-not-exists - settings: - dry_run: true - repo: plugins/github-actions - dockerfile: docker/Dockerfile.linux.amd64 - tags: - - latest - - name: publish image: plugins/docker pull: if-not-exists