Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emscripten compilation broken #2

Closed
toby-bro opened this issue May 17, 2024 · 1 comment · Fixed by #3
Closed

emscripten compilation broken #2

toby-bro opened this issue May 17, 2024 · 1 comment · Fixed by #3

Comments

@toby-bro
Copy link

toby-bro commented May 17, 2024

emscripten compilation is broken. for two reasons :

  • glDrawBuffer
  • GL_TEXTURE_BORDER
    gcc can compile cgp as glDrawBuffer is defined in glad.h but it is not in gl3.h so this line cannot be compiled as is by emscripten.

By the way this same commit seems to break emscripten compilation because there is no GL_TEXTURE_BORDER in gl3.h. But there is one in gl32.h so if we modify this line to #include <GLES3/gl32.h> we can fix this second issue.

toby-bro added a commit to toby-bro/cgp that referenced this issue May 17, 2024
@drohmer
Copy link
Owner

drohmer commented May 18, 2024

Thanks a lot !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants