Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rate Limiting #5

Open
Tracked by #1
nathanclevenger opened this issue Sep 1, 2022 · 2 comments
Open
Tracked by #1

Add Rate Limiting #5

nathanclevenger opened this issue Sep 1, 2022 · 2 comments

Comments

@nathanclevenger
Copy link
Member

No description provided.

@sam-lippert
Copy link
Contributor

@nathanclevenger How should this be implemented? My first thought is to record every transaction to be counted and clear them out if the previous transaction was last month. With that, we also need to be able to determine the user's access plan to check the number of requests against the limit. Should that come from another service?

@nathanclevenger
Copy link
Member Author

I'm thinking of keeping a counter which is year-month and so we always increment, never clear ... and we can see historical trends ... it's basically a counter by month ... separately we could use a counter by minute (maybe just a rounded ticks to be 100 sec for simplicity?) in the DO for rate limiting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants