Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I suspect that content-type should be case insensitive #183

Open
MichaelWehar opened this issue Apr 20, 2020 · 2 comments
Open

I suspect that content-type should be case insensitive #183

MichaelWehar opened this issue Apr 20, 2020 · 2 comments

Comments

@MichaelWehar
Copy link

MichaelWehar commented Apr 20, 2020 •
edited
Loading

node-XMLHttpRequest/lib/XMLHttpRequest.js

Line 369 in 97966e4

if (!this.getRequestHeader("Content-Type")) {

Currently, it appears that it assumes content-type is written as "Content-Type".
@MichaelWehar
Copy link
Author

See here: https://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html#sec4.2

"Field names are case-insensitive."

@MythicManiac
Copy link

I just hit a bug due to this, a client was setting content-type instead of the Content-Type that was being checked for, causing breakage.

@MythicManiac MythicManiac mentioned this issue May 27, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MythicManiac @MichaelWehar