Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is abort() called at the top of open()? #156

Open
ahicox opened this issue Dec 29, 2017 · 1 comment
Open

Why is abort() called at the top of open()? #156

ahicox opened this issue Dec 29, 2017 · 1 comment

Comments

@ahicox
Copy link

ahicox commented Dec 29, 2017

Line 157 in XMLHTTPRequest.js:

this.open = function(method, url, async, user, password) { this.abort(); errorFlag = false;

This causes all calls to open(), to immediately invoke the 'abort' event on the XHR object. Presuming you are catching the 'abort' event, this will of course, abort every single call you try to make?

am I missing something here?
This basically breaks open()?

Did someone break this on purpose because the module is deprecated or something?
just commenting that out so I can get along with what I was trying to do, but if it's broke on purpose someone should update README.md.

@SamuelToh
Copy link

Interesting. I would like to know as well.

I thought I'll try removing it manually, run the test to see if there is any quick hints to explain this. But I have no idea how the tests can be executed. I have thus raised #177 to address it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants