Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set split proportions to None if split column is provided #198

Open
ejm714 opened this issue Jul 11, 2022 · 2 comments
Open

Set split proportions to None if split column is provided #198

ejm714 opened this issue Jul 11, 2022 · 2 comments
Labels
good first issue Good for newcomers

Comments

@ejm714
Copy link
Collaborator

ejm714 commented Jul 11, 2022

If a user just provides a split column, they'll get the default split proportions. This leads to the message

Labels contains split column yet split_proportions are also provided. Split column in labels takes precedence.

which is a bit confusing if a user doesn't intentionally provide split proportions. It'd be nice if we detect splits in the labels csv to set split proportions to None, so that this warning only shows up if a user intentionally provides both.

This won't change underlying behavior, just make the logging more intuitive.

@ejm714 ejm714 changed the title Set split proportions to none if split column is provided Set split proportions to None if split column is provided Jul 11, 2022
@klwetstone klwetstone added the good first issue Good for newcomers label Apr 17, 2024
@aaronphilip19
Copy link

Hey, @sambujangfofana and I are students from the University of Michigan. We are currently working on a project wherein we have to contribute to a Github repository(https://eecs481.org/hw6.html). We are pretty interested in this issue and would want to work on it. We hope to submit a pull request this week. Could we be assigned this issue?

@slimkevo
Copy link

slimkevo commented Aug 2, 2024

Could I please be assigned to this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants