New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize default for model_cache_dir across repo #183

Open

1 task

klwetstone opened this issue Apr 6, 2022 · 1 comment

Open

1 task

Standardize default for model_cache_dir across repo #183

klwetstone opened this issue Apr 6, 2022 · 1 comment

Labels

enhancement good first issue

Contributor

klwetstone commented Apr 6, 2022

For densepose, there are multiple different default values specified for the model cache directory between the CLI and the python package

In cli.py, says env variable ZAMBA_CACHE_DIR. It doesn't look like you can actually set it with this env variable
In models.config.validate_model_cache_dir it's MODEL_CACHE_DIR
In models.densepose.densepose_manager.DensePoseManager it's .zamba_cache
use the same default cache dir throughout the repo - ZAMBA_CACHE_DIR in env likely makes more sense than MODEL_CACHE_DIR

The text was updated successfully, but these errors were encountered:

klwetstone added enhancement good first issue labels

ghagevaibhav commented Jun 1, 2024

Is the issue still open and Can I work on it as my first issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment