Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruff lint configuration names are incorrect #388

Open
r-b-g-b opened this issue Jun 20, 2024 · 1 comment · May be fixed by #387
Open

Ruff lint configuration names are incorrect #388

r-b-g-b opened this issue Jun 20, 2024 · 1 comment · May be fixed by #387
Assignees
@chrisjkuch
Labels
v2-bug

Comments

@r-b-g-b
Copy link
Contributor

r-b-g-b commented Jun 20, 2024 •
edited
Loading

To reproduce:

  1. Create a new cookiecutter-data-science repo
  2. Run ruff lint .

Error:

Ruff: Lint failed (ruff failed
  Cause: Failed to parse /home/.../pyproject.toml
  Cause: TOML parse error at line 30, column 12
   |
30 | [tool.ruff.lint.isort]
   |            ^^^^
unknown field `known_first_party`, expected one of `force-wrap-aliases`, `force-single-line`, `single-line-exclusions`, `combine-as-imports`, `split-on-trailing-comma`, `order-by-type`, `force-sort-within-sections`, `case-sensitive`, `force-to-top`, `known-first-party`, `known-third-party`, `known-local-folder`, `extra-standard-library`, `relative-imports-order`, `required-imports`, `classes`, `constants`, `variables`, `no-lines-before`, `lines-after-imports`, `lines-between-types`, `forced-separate`, `section-order`, `default-section`, `no-sections`, `detect-same-package`, `from-first`, `length-sort`, `length-sort-straight`, `sections`
)

It appears that the pyproject.toml ruff configuration setting names are incorrect -- they should use hyphens rather than underscores as separators.

https://docs.astral.sh/ruff/configuration/
@r-b-g-b r-b-g-b added the v2-bug label Jun 20, 2024
@r-b-g-b
Copy link
Contributor Author

r-b-g-b commented Jun 20, 2024

Possibly fixed by #387

@chrisjkuch chrisjkuch self-assigned this Jun 20, 2024
@chrisjkuch chrisjkuch linked a pull request Jun 20, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisjkuch chrisjkuch

Labels
v2-bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ruff as default linting + formatting option drivendataorg/cookiecutter-data-science
2 participants
@r-b-g-b @chrisjkuch