Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QuickTime: Regression in parsing GPS Location #432

Open
KirkLandTrip opened this issue Feb 9, 2025 · 1 comment · May be fixed by #433
Open

QuickTime: Regression in parsing GPS Location #432

KirkLandTrip opened this issue Feb 9, 2025 · 1 comment · May be fixed by #433

Comments

@KirkLandTrip
Copy link
Contributor

Hey,
I used to work with Metadata Extractor in version 2.7.x and got QuickTime locations values.
I switched to the latest code from main and the locations aren't parsed anymore.

I traced the error to this line in QuickTimeMetadataReader, in the UserDataHandler function:
Image

It's trying to read the "type" as a string and it comes out as "©xyz". The code is expecting ?xyz.
The binary value is 0xa978797a and the 0xa9 byte is the culprit. Since it's defined "outside of the ASCII" range, it gets interpreted differently in some cases.
I'm not sure if my locale (en-GB) or switching from .NET framework to .NET 7 cause this, but at least some users beside me are going to experience it.
@KirkLandTrip KirkLandTrip linked a pull request Feb 9, 2025 that will close this issue
Open
@KirkLandTrip
Copy link
Contributor Author

@drewnoakes

I created a PR that changes the type checking to use the int value instead of the converted string.
That should work across .NET versions and locales.
Can you please have a look?
#433

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

QuickTime: Fix parsing of the GPS tag (xyz) KirkLandTrip/metadata-extractor-dotnet
1 participant
@KirkLandTrip