Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set podSecurityContext for the dragonfly custom resource #229

Open
sisrael-dn opened this issue Aug 13, 2024 · 3 comments
Open

Set podSecurityContext for the dragonfly custom resource #229

sisrael-dn opened this issue Aug 13, 2024 · 3 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@sisrael-dn
Copy link

sisrael-dn commented Aug 13, 2024

Hello,

Right now the dragonfly crd doesn't seem to support setting any podSecurityContext (correct me if I'm wrong) which will be passed for the pods running dragonfly.
Would it it possible to add this please?

So We can create for example something like:

apiVersion: dragonflydb.io/v1alpha1
kind: Dragonfly
metadata:
  labels:
    app.kubernetes.io/name: dragonfly-sample
    app.kubernetes.io/instance: dragonfly
    app.kubernetes.io/part-of: dragonfly-operator
    app.kubernetes.io/managed-by: helm
    app.kubernetes.io/created-by: dragonfly-operator
  name: dragonfly-sample
spec:
  podSecurityContext:
    capabilities:
      add: ["IPC_LOCK"]
@Pothulapati
Copy link
Collaborator

Hey @sisrael-dn, You are right that we don't support setting podSecurityContext through Dragonfly resource for Dragonfly pods.

This isn't a high priority right now, Can you raise a PR to add this configuration into https://github.com/dragonflydb/dragonfly-operator/blob/main/api/v1alpha1/dragonfly_types.go#L28

@Pothulapati Pothulapati added good first issue Good for newcomers help wanted Extra attention is needed labels Aug 14, 2024
@sisrael-dn
Copy link
Author

Hi @Pothulapati , I understand, thank you for pointing me to the right place to add it.
I'll try to raise a PR as suggested when I'll have some free time (:

@jonathon2nd
Copy link

jonathon2nd commented Nov 27, 2024

This will be needed to fix Weird error 1 switching to epoll

dragonflydb/dragonfly#4042

Or maybe not?
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants