Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instance unresponsive, pods not restarting #223

Open
thecodeassassin opened this issue Jul 24, 2024 · 1 comment
Open

Instance unresponsive, pods not restarting #223

thecodeassassin opened this issue Jul 24, 2024 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@thecodeassassin
Copy link
Contributor

Hi,

The current way of doing healthchecks seems somewhat insufficient for auto-healing.

Our instance became unreponsive to commands such as GET, SET, MONITOR etc but the healthchecks were still succeeding (ping/pong).

My suggestion therefore is that the current healthcheck should either be user-configurable or a more thorough healtcheck could be done such as incrementing a value.

@Abhra303
Copy link
Contributor

Hi @thecodeassassin , I think this is the wrong repo for this issue as the healthcheck is defined here https://github.com/dragonflydb/dragonfly/blob/main/tools/docker/healthcheck.sh. Please open an issue in the dragonfly repo.

I agree with your observation that healthcheck can be improved. Feel free to open a PR!

@Pothulapati Pothulapati added good first issue Good for newcomers help wanted Extra attention is needed labels Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants