From 82c64208fd5fa6d573191b864b1c2d4232f68739 Mon Sep 17 00:00:00 2001 From: Caitlin Date: Fri, 13 Sep 2024 11:38:04 -0400 Subject: [PATCH 1/3] use consistent thor task naming --- lib/tasks/thorfile.rb | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/tasks/thorfile.rb b/lib/tasks/thorfile.rb index dd86f68..2b733c8 100644 --- a/lib/tasks/thorfile.rb +++ b/lib/tasks/thorfile.rb @@ -1,10 +1,10 @@ class QualysTasks < Thor include Rails.application.config.dradis.thor_helper_module - namespace "dradis:plugins:qualys" + namespace "dradis:plugins:qualys:upload" - desc "upload FILE", "upload Qualys XML results" - def upload(file_path) + desc "vuln FILE", "upload Qualys Vuln XML results" + def vuln(file_path) require 'config/environment' unless File.exists?(file_path) @@ -18,8 +18,8 @@ def upload(file_path) importer.import(file: file_path) end - desc "upload_was FILE", "upload Qualys WAS XML results" - def upload_was(file_path) + desc "was FILE", "upload Qualys WAS XML results" + def was(file_path) require 'config/environment' unless File.exists?(file_path) From 1d6ce3f323eb32d243cf8e50fe5941522f586a6f Mon Sep 17 00:00:00 2001 From: Caitlin Date: Fri, 13 Sep 2024 11:40:58 -0400 Subject: [PATCH 2/3] changelog --- CHANGELOG.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5e8bcbf..e3f0226 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,6 @@ +vX.XX.X (Month 2024) + - Update thor task names for consistency + v4.13.0 (July 2024) - No changes From 0f1e0c3c9ae36ac1f1e7cf4eb1fddbfe5bf0629b Mon Sep 17 00:00:00 2001 From: Caitlin Date: Wed, 18 Sep 2024 15:18:02 -0400 Subject: [PATCH 3/3] add success messages to importer import methods --- lib/dradis/plugins/qualys/asset/importer.rb | 1 + lib/dradis/plugins/qualys/vuln/importer.rb | 1 + lib/dradis/plugins/qualys/was/importer.rb | 1 + 3 files changed, 3 insertions(+) diff --git a/lib/dradis/plugins/qualys/asset/importer.rb b/lib/dradis/plugins/qualys/asset/importer.rb index 9839868..0926fe9 100644 --- a/lib/dradis/plugins/qualys/asset/importer.rb +++ b/lib/dradis/plugins/qualys/asset/importer.rb @@ -48,6 +48,7 @@ def import(params={}) process_node(xml_node) end + logger.info { 'Qualys Asset file successfully imported' } true end diff --git a/lib/dradis/plugins/qualys/vuln/importer.rb b/lib/dradis/plugins/qualys/vuln/importer.rb index 6c1fe88..97f2995 100644 --- a/lib/dradis/plugins/qualys/vuln/importer.rb +++ b/lib/dradis/plugins/qualys/vuln/importer.rb @@ -43,6 +43,7 @@ def import(params={}) process_ip(xml_host) end + logger.info { 'Qualys Vuln file successfully imported' } return true end diff --git a/lib/dradis/plugins/qualys/was/importer.rb b/lib/dradis/plugins/qualys/was/importer.rb index ec4b31a..0f819a9 100644 --- a/lib/dradis/plugins/qualys/was/importer.rb +++ b/lib/dradis/plugins/qualys/was/importer.rb @@ -61,6 +61,7 @@ def import(params = {}) process_evidence(xml_vulnerability) end + logger.info { 'Qualys WAS file successfully imported' } true end