From 6021142cfc2a6993a51a4f5c46aa6923a25cf143 Mon Sep 17 00:00:00 2001 From: Yeni Atencio Date: Mon, 5 Jun 2023 12:12:05 +1000 Subject: [PATCH 1/3] remove call to function getExposedItemsToLoadField and required src to responsive img --- packages/components/Atoms/ResponsiveImg/ResponsiveImg.vue | 4 +--- .../modules/landing-page/lib/content-collection.js | 1 - 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/packages/components/Atoms/ResponsiveImg/ResponsiveImg.vue b/packages/components/Atoms/ResponsiveImg/ResponsiveImg.vue index 83b89a161..711d8fd02 100644 --- a/packages/components/Atoms/ResponsiveImg/ResponsiveImg.vue +++ b/packages/components/Atoms/ResponsiveImg/ResponsiveImg.vue @@ -20,9 +20,7 @@ export default { mixins: [breakpoint], props: { src: { - type: String, - required: true - }, + type: String }, alt: { type: String }, diff --git a/packages/ripple-nuxt-tide/modules/landing-page/lib/content-collection.js b/packages/ripple-nuxt-tide/modules/landing-page/lib/content-collection.js index b45fcc25b..2ce173c59 100644 --- a/packages/ripple-nuxt-tide/modules/landing-page/lib/content-collection.js +++ b/packages/ripple-nuxt-tide/modules/landing-page/lib/content-collection.js @@ -826,7 +826,6 @@ module.exports = class ContentCollection { getExposedControlFields () { const controls = [ this.getExposedSortField(), - this.getExposedItemsToLoadField() ] return controls.filter(item => item !== null) } From db5b26495ea534d6989193279514d3dcb55d3b31 Mon Sep 17 00:00:00 2001 From: Yeni Atencio Date: Mon, 5 Jun 2023 12:26:12 +1000 Subject: [PATCH 2/3] fix lint --- packages/components/Atoms/ResponsiveImg/ResponsiveImg.vue | 3 ++- .../modules/landing-page/lib/content-collection.js | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/components/Atoms/ResponsiveImg/ResponsiveImg.vue b/packages/components/Atoms/ResponsiveImg/ResponsiveImg.vue index 711d8fd02..318edb578 100644 --- a/packages/components/Atoms/ResponsiveImg/ResponsiveImg.vue +++ b/packages/components/Atoms/ResponsiveImg/ResponsiveImg.vue @@ -20,7 +20,8 @@ export default { mixins: [breakpoint], props: { src: { - type: String }, + type: String + }, alt: { type: String }, diff --git a/packages/ripple-nuxt-tide/modules/landing-page/lib/content-collection.js b/packages/ripple-nuxt-tide/modules/landing-page/lib/content-collection.js index 2ce173c59..beaab8be8 100644 --- a/packages/ripple-nuxt-tide/modules/landing-page/lib/content-collection.js +++ b/packages/ripple-nuxt-tide/modules/landing-page/lib/content-collection.js @@ -825,7 +825,7 @@ module.exports = class ContentCollection { getExposedControlFields () { const controls = [ - this.getExposedSortField(), + this.getExposedSortField() ] return controls.filter(item => item !== null) } From 3ad71a0255819b275648a212f4dd16b5cee8dfe6 Mon Sep 17 00:00:00 2001 From: Yeni Atencio Date: Thu, 8 Jun 2023 13:15:15 +1000 Subject: [PATCH 3/3] revert --- packages/components/Atoms/ResponsiveImg/ResponsiveImg.vue | 3 ++- .../modules/landing-page/lib/content-collection.js | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/components/Atoms/ResponsiveImg/ResponsiveImg.vue b/packages/components/Atoms/ResponsiveImg/ResponsiveImg.vue index 318edb578..83b89a161 100644 --- a/packages/components/Atoms/ResponsiveImg/ResponsiveImg.vue +++ b/packages/components/Atoms/ResponsiveImg/ResponsiveImg.vue @@ -20,7 +20,8 @@ export default { mixins: [breakpoint], props: { src: { - type: String + type: String, + required: true }, alt: { type: String diff --git a/packages/ripple-nuxt-tide/modules/landing-page/lib/content-collection.js b/packages/ripple-nuxt-tide/modules/landing-page/lib/content-collection.js index beaab8be8..10ccb67e2 100644 --- a/packages/ripple-nuxt-tide/modules/landing-page/lib/content-collection.js +++ b/packages/ripple-nuxt-tide/modules/landing-page/lib/content-collection.js @@ -826,6 +826,7 @@ module.exports = class ContentCollection { getExposedControlFields () { const controls = [ this.getExposedSortField() + this.getExposedItemsToLoadField() ] return controls.filter(item => item !== null) }