Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instead of just removing version when using unconstrain-version the id is blanked #40

Open
1 of 3 tasks
ThorvaldAagaard opened this issue Jun 22, 2019 · 0 comments
Open
1 of 3 tasks

Comments

@ThorvaldAagaard
Copy link

I'm submitting a ... (check one with "x"):

  • bug report
  • feature request
  • documentation issue

Bug report

Everything after first @ is stripped to remove version, that conflict with plugins, where @ is included in the id

Current behavior:

Using plugin
"@mauron85/cordova-plugin-background-geolocation": "^3.0.3",

cordova-check-plugins fails when this code is executed

var idToCheck = unconstrainVersions ? source.id.replace(/(@([^~]?).*)$/, '') : source.id;

as idToCheck now is blank

Check for version fails

Changing the regex to @([^@]+)$ that takes the last @ solves the problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant