Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bolas stun appears to be permanent #703

Open
avengah opened this issue Sep 24, 2022 · 2 comments · May be fixed by #704
Open

Bolas stun appears to be permanent #703

avengah opened this issue Sep 24, 2022 · 2 comments · May be fixed by #704

Comments

@avengah
Copy link

avengah commented Sep 24, 2022

Reading the code, it looks like it's intended to be a 4 second stun, but once the timer runs out, the enemy doesn't start attacking again. Once one bolas hits, the enemy is completely out of commission for the rest of the fight and you can take as long as you want.
@SarahisCode
Copy link

Hmm, I think I might have seen that issue myself. Where in the code does it say it's supposed to be a 4 second stun?

@SarahisCode SarahisCode linked a pull request Feb 23, 2023 that will close this issue
Open
@SarahisCode
Copy link

I think what's going on is that the stun is made via setting the 'stunned' attribute of the enemy to the specified stun time. But that attribute isn't touched again, so enemyAttack sees the time every time it's run, says, "Yep, that's truthy", and doesn't do anything for the rest of the fight, causing the enemy to be permastunned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

made stuns non-permanent SarahisCode/adarkroom
2 participants
@avengah @SarahisCode