Skip to content

Move files related to Python bindings in the bindings/python subfolder #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yvan-sraka opened this issue Feb 6, 2025 · 1 comment
Closed

Move files related to Python bindings in the bindings/python subfolder #170

yvan-sraka opened this issue Feb 6, 2025 · 1 comment
Labels
duplicate This issue or pull request already exists

Comments

@yvan-sraka
Copy link
Contributor

Everything that's related to Python bindings (including tests) should go in the bindings/python directory, like HF did with its tokenizers library for instance.

Originally posted by @rlouf in #141 (comment)
@torymur torymur added the duplicate This issue or pull request already exists label Feb 6, 2025
@torymur
Copy link
Contributor

torymur commented Feb 6, 2025

Sorry, this is a duplicate of this: #153

@torymur torymur closed this as completed Feb 6, 2025
@torymur torymur mentioned this issue Feb 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yvan-sraka @torymur